js icon indicating copy to clipboard operation
js copied to clipboard
verified publisher icon thirdweb-dev

AWS KMS Wallet POC

Open d4mr opened this issue 11 months ago • 6 comments

PR-Codex overview

This PR introduces the @thirdweb-dev/aws-kms-wallet package, providing AWS KMS wallet functionality for the thirdweb SDK. It includes a new utility function for chain handling, updates to configuration files, and comprehensive usage documentation.

Detailed summary

  • Added getChain function in src/utils/chain.ts to return chain information.
  • Created tsconfig.build.json for TypeScript configuration.
  • Updated README.md with installation instructions, usage examples, and requirements.
  • Defined package metadata in package.json for @thirdweb-dev/aws-kms-wallet.
  • Implemented AWS KMS account functionality in src/index.ts, including transaction signing and message signing methods.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

d4mr avatar Feb 11 '25 21:02 d4mr

⚠️ No Changeset found

Latest commit: 3fee8df37bfd96a1d517c40b316cc14371c281ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 11 '25 21:02 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 11, 2025 9:52pm
login ⬜️ Skipped (Inspect) Feb 11, 2025 9:52pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 11, 2025 9:52pm
thirdweb-www ⬜️ Skipped (Inspect) Feb 11, 2025 9:52pm
wallet-ui ⬜️ Skipped (Inspect) Feb 11, 2025 9:52pm

vercel[bot] avatar Feb 11 '25 21:02 vercel[bot]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

graphite-app[bot] avatar Feb 11 '25 21:02 graphite-app[bot]

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, shell +16 2.82 MB aws-sdk-bot
npm/[email protected] None +4 2.25 MB odanado
npm/[email protected] Transitive: environment +15 46.9 MB thirdweb-bot

View full report↗︎

socket-security[bot] avatar Feb 11 '25 21:02 socket-security[bot]

Problems:

  1. Exported types: some required types are not exported from thirdweb
  2. getCachedChain is not exported, and since I only have a chainId I cannot resolve a chain in case the user has chain overrides

d4mr avatar Feb 11 '25 21:02 d4mr

This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.

github-actions[bot] avatar Feb 20 '25 01:02 github-actions[bot]