[SDK] Feature: Add support for forcing legacy transactions in chain configuration
PR-Codex overview
This PR introduces enhancements to transaction handling by adding support for various transaction types and fee structures. It refines how transactions are prepared and processed, ensuring compatibility with different Ethereum transaction standards.
Detailed summary
- Added
feeTypetoChainOptions. - Introduced
TransactionTypewith multiple variants. - Implemented
TransactionTypeMapfor type mapping. - Updated transaction serialization to include
type. - Enhanced gas fee handling to prioritize transaction fee types.
- Added
FeeTypefor legacy and EIP1559 classifications.
✨ Ask PR-Codex anything about this PR by commenting with
/codex {your question}
⚠️ No Changeset found
Latest commit: 66fbe309aeec02667c45f1d2cb0e4f2b36f3e65b
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| docs-v2 | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2025 11:52am |
| login | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2025 11:52am |
| thirdweb_playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2025 11:52am |
| thirdweb-www | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2025 11:52am |
| wallet-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 26, 2025 11:52am |
How to use the Graphite Merge Queue
Add either label to this PR to merge it via the merge queue:
- merge-queue - adds this PR to the back of the merge queue
- hotfix - for urgent hot fixes, skip the queue and merge this PR next
You must have a Graphite account in order to use the merge queue. Sign up using this link.
An organization admin has enabled the Graphite Merge Queue in this repository.
Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.
size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| thirdweb (esm) | 46.56 KB (+0.01% 🔺) | 932 ms (+0.01% 🔺) | 591 ms (+65.27% 🔺) | 1.6 s |
| thirdweb (cjs) | 124.42 KB (+0.14% 🔺) | 2.5 s (+0.14% 🔺) | 814 ms (-21.18% 🔽) | 3.4 s |
| thirdweb (minimal + tree-shaking) | 5.6 KB (0%) | 112 ms (0%) | 135 ms (+75.33% 🔺) | 247 ms |
| thirdweb/chains (tree-shaking) | 506 B (0%) | 10 ms (0%) | 61 ms (+309.82% 🔺) | 71 ms |
| thirdweb/react (minimal + tree-shaking) | 19.35 KB (0%) | 387 ms (0%) | 207 ms (+49.53% 🔺) | 594 ms |
Codecov Report
Attention: Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.
Project coverage is 56.84%. Comparing base (
35b7a0e) to head (842c37e). Report is 43 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| packages/thirdweb/src/gas/fee-data.ts | 76.00% | 5 Missing and 1 partial :warning: |
| packages/thirdweb/src/adapters/ethers5.ts | 50.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #6180 +/- ##
=======================================
Coverage 56.83% 56.84%
=======================================
Files 1168 1168
Lines 64789 64818 +29
Branches 5259 5264 +5
=======================================
+ Hits 36825 36843 +18
- Misses 27237 27248 +11
Partials 727 727
| Flag | Coverage Δ | *Carryforward flag | |
|---|---|---|---|
| legacy_packages | 65.68% <ø> (ø) |
Carriedforward from b2b1e46 | |
| packages | 55.05% <91.02%> (+<0.01%) |
:arrow_up: |
*This pull request uses carry forward flags. Click here to find out more.
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...transaction/actions/to-serializable-transaction.ts | 78.72% <100.00%> (+2.81%) |
:arrow_up: |
| ...es/thirdweb/src/transaction/prepare-transaction.ts | 100.00% <100.00%> (ø) |
|
| packages/thirdweb/src/adapters/ethers5.ts | 53.82% <50.00%> (-0.02%) |
:arrow_down: |
| packages/thirdweb/src/gas/fee-data.ts | 71.60% <76.00%> (-2.26%) |
:arrow_down: |
This PR has been inactive for 7 days. It is now marked as stale and will be closed in 2 days if no further activity occurs.