js icon indicating copy to clipboard operation
js copied to clipboard

v5 deploy dashboard changes

Open jnsdls opened this issue 1 year ago • 6 comments

PR-Codex overview

This PR focuses on restructuring routes and updating deprecated functions.

Detailed summary

  • Removed several components and pages related to publishing and contracts
  • Updated deprecated functions and imports
  • Added new routes and components for contract deployment and actions

The following files were skipped due to too many changes: packages/thirdweb/package.json, apps/dashboard/src/components/contract-components/contract-deploy-form/trusted-forwarders-fieldset.tsx, apps/dashboard/src/app/(dashboard)/published-contract/components/contract-header.tsx, apps/dashboard/src/app/(dashboard)/published-contract/components/contract-info.tsx, apps/dashboard/src/components/contract-components/contract-deploy-form/contract-metadata-fieldset.tsx, apps/dashboard/src/components/contract-components/fetch-contracts-with-versions.ts, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/components/breadcrumbs.client.tsx, apps/dashboard/src/contract-ui/tabs/manage/components/getModuleInstalledParams.ts, packages/thirdweb/src/utils/abi/normalizeFunctionParams.ts, apps/dashboard/src/app/(dashboard)/published-contract/components/version-selector.tsx, apps/dashboard/src/app/(dashboard)/published-contract/components/publish-based-deploy.tsx, apps/dashboard/src/components/contract-functions/contract-function.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/page.tsx, apps/dashboard/src/app/(dashboard)/published-contract/[publisher]/[contract_id]/[version]/page.tsx, apps/dashboard/src/@/components/ui/breadcrumb.tsx, packages/thirdweb/src/extensions/prebuilts/get-required-transactions.ts, apps/dashboard/src/components/contract-components/published-contract/index.tsx, apps/dashboard/src/components/contract-components/hooks.ts, apps/dashboard/src/components/contract-components/contract-deploy-form/custom-contract.tsx, pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

jnsdls avatar Sep 10 '24 00:09 jnsdls

⚠️ No Changeset found

Latest commit: ece86ccdc39862edef0c6dac916d3066853a9143

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 10 '24 00:09 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ❌ Failed (Inspect) Sep 13, 2024 8:15pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:15pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:15pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 8:15pm

vercel[bot] avatar Sep 10 '24 00:09 vercel[bot]

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Sep 10 '24 00:09 graphite-app[bot]

  • #4574 Graphite
  • #4567 Graphite
  • #4552 Graphite
  • #4498 Graphite 👈
  • #4499 Graphite
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

jnsdls avatar Sep 10 '24 00:09 jnsdls

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.61 KB (-0.13% 🔽) 873 ms (-0.13% 🔽) 2.9 s (-10.92% 🔽) 3.8 s
thirdweb (cjs) 100.93 KB (-0.11% 🔽) 2.1 s (-0.11% 🔽) 8.1 s (+62.28% 🔺) 10.1 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 97 ms (0%) 312 ms (+28.85% 🔺) 409 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 302 ms (+183.75% 🔺) 312 ms
thirdweb/react (minimal + tree-shaking) 16.68 KB (0%) 334 ms (0%) 347 ms (-5.24% 🔽) 680 ms

github-actions[bot] avatar Sep 10 '24 00:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 64.70588% with 66 lines in your changes missing coverage. Please review.

Project coverage is 49.53%. Comparing base (5d3b395) to head (ece86cc). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../extensions/prebuilts/get-required-transactions.ts 55.55% 56 Missing :warning:
.../thirdweb/src/utils/abi/normalizeFunctionParams.ts 65.21% 8 Missing :warning:
...hirdweb/src/contract/deployment/deploy-with-abi.ts 89.47% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4498      +/-   ##
==========================================
+ Coverage   49.51%   49.53%   +0.01%     
==========================================
  Files        1017     1017              
  Lines       53866    53998     +132     
  Branches     3762     3767       +5     
==========================================
+ Hits        26674    26750      +76     
- Misses      26559    26615      +56     
  Partials      633      633              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 5d3b395
packages 45.46% <64.70%> (+0.03%) :arrow_up:

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...rdweb/src/extensions/prebuilts/deploy-published.ts 81.52% <100.00%> (+0.45%) :arrow_up:
packages/thirdweb/src/gas/fee-data.ts 68.00% <100.00%> (+0.87%) :arrow_up:
...ages/thirdweb/src/utils/any-evm/deploy-metadata.ts 88.23% <100.00%> (+0.23%) :arrow_up:
...b/src/utils/any-evm/get-init-bytecode-with-salt.ts 95.23% <100.00%> (ø)
...es/thirdweb/src/utils/contract/parse-abi-params.ts 100.00% <100.00%> (ø)
...hirdweb/src/contract/deployment/deploy-with-abi.ts 91.02% <89.47%> (-1.29%) :arrow_down:
.../thirdweb/src/utils/abi/normalizeFunctionParams.ts 75.00% <65.21%> (+8.33%) :arrow_up:
.../extensions/prebuilts/get-required-transactions.ts 67.97% <55.55%> (-29.46%) :arrow_down:

codecov[bot] avatar Sep 10 '24 00:09 codecov[bot]

Merge activity

  • Sep 13, 3:15 PM EDT: jnsdls added this pull request to the Graphite merge queue.
  • Sep 13, 3:33 PM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Vercel – thirdweb-www').
  • Sep 13, 4:16 PM EDT: jnsdls added this pull request to the Graphite merge queue.
  • Sep 13, 4:16 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

graphite-app[bot] avatar Sep 13 '24 19:09 graphite-app[bot]