feat(thirdweb): Add support for discord auth in in app wallet
Problem solved
Short description of the bug fixed or feature added
Changes made
- [ ] Public API changes: list the public API changes made if any
- [ ] Internal API changes: explain the internal logic changes
How to test
- [ ] Automated tests: link to unit test file
- [ ] Manual tests: step by step instructions on how to test
Contributor NFT
Paste in your wallet address below and we will airdrop you a special NFT when your pull request is merged.
Address:
PR-Codex overview
This PR adds Discord login support to thirdweb in-app and ecosystem wallets.
Detailed summary
- Added
signInWithDiscordoption for social login - Updated authentication interfaces for Discord
- Implemented Discord login functionality
- Updated UI components to include Discord login option
The following files were skipped due to too many changes:
packages/thirdweb/src/react/native/ui/icons/svgs.ts,packages/thirdweb/src/wallets/in-app/web/lib/auth/discord.ts,pnpm-lock.yaml
✨ Ask PR-Codex anything about this PR by commenting with
/codex {your question}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| thirdweb_playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 19, 2024 9:34pm |
| thirdweb-www | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 19, 2024 9:34pm |
| wallet-ui | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jul 19, 2024 9:34pm |
🦋 Changeset detected
Latest commit: 31ee4e53e2e42ecda3790c7a4bd08f4d5e2c1aaa
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| thirdweb | Minor |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Your org requires the Graphite merge queue for merging into main
Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.
You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.
CodSpeed Performance Report
Merging #3678 will not alter performance
Comparing winston/discord-auth (31ee4e5) with main (ec5ef50)
Summary
✅ 9 untouched benchmarks
Codecov Report
Attention: Patch coverage is 15.88785% with 180 lines in your changes missing coverage. Please review.
Project coverage is 61.32%. Comparing base (
ec5ef50) to head (31ee4e5).
Additional details and impacted files
@@ Coverage Diff @@
## main #3678 +/- ##
==========================================
- Coverage 61.61% 61.32% -0.29%
==========================================
Files 925 930 +5
Lines 73109 73606 +497
Branches 3726 3727 +1
==========================================
+ Hits 45047 45140 +93
- Misses 27380 27784 +404
Partials 682 682
| Flag | Coverage Δ | *Carryforward flag | |
|---|---|---|---|
| legacy_packages | 65.66% <ø> (ø) |
Carriedforward from ec5ef50 | |
| packages | 60.57% <15.88%> (-0.34%) |
:arrow_down: |
*This pull request uses carry forward flags. Click here to find out more.
| Files | Coverage Δ | |
|---|---|---|
| ...kages/thirdweb/src/react/core/utils/socialIcons.ts | 100.00% <100.00%> (ø) |
|
| ...web/src/wallets/in-app/core/authentication/type.ts | 100.00% <100.00%> (ø) |
|
| ...rdweb/src/wallets/in-app/web/lib/auth/constants.ts | 100.00% <100.00%> (ø) |
|
| packages/thirdweb/src/wallets/types.ts | 100.00% <100.00%> (ø) |
|
| ...irdweb/src/react/web/ui/components/WalletImage.tsx | 19.33% <25.00%> (+0.15%) |
:arrow_up: |
| ...irdweb/src/wallets/in-app/web/lib/web-connector.ts | 11.20% <9.09%> (-0.11%) |
:arrow_down: |
| ...rdweb/src/react/web/wallets/shared/SocialLogin.tsx | 13.29% <8.33%> (-0.29%) |
:arrow_down: |
| .../thirdweb/src/wallets/in-app/web/lib/auth/utils.ts | 5.26% <5.26%> (ø) |
|
| .../web/wallets/shared/ConnectWalletSocialOptions.tsx | 25.06% <17.39%> (-0.68%) |
:arrow_down: |
| .../react/web/wallets/shared/openOauthSignInWindow.ts | 52.14% <17.85%> (-6.84%) |
:arrow_down: |
| ... and 1 more |
size-limit report 📦
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| thirdweb (esm) | 43.27 KB (0%) | 866 ms (0%) | 2.9 s (+3.75% 🔺) | 3.8 s |
| thirdweb (cjs) | 91.39 KB (0%) | 1.9 s (0%) | 8 s (+19.92% 🔺) | 9.8 s |
| thirdweb (minimal + tree-shaking) | 4.82 KB (0%) | 97 ms (0%) | 242 ms (+9.57% 🔺) | 338 ms |
| thirdweb/chains (tree-shaking) | 433 B (0%) | 10 ms (0%) | 166 ms (+196.19% 🔺) | 176 ms |
| thirdweb/react (minimal + tree-shaking) | 13.54 KB (0%) | 271 ms (0%) | 752 ms (-34.24% 🔽) | 1.1 s |
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @ElasticBottle and the rest of your teammates on
Graphite
Merge activity
-
Jul 19, 5:04 PM EDT:
gregfromstladded this pull request to the Graphite merge queue. -
Jul 19, 5:34 PM EDT:
gregfromstlmerged this pull request with the Graphite merge queue.