js icon indicating copy to clipboard operation
js copied to clipboard

[Feature] Add Engine Account support

Open jnsdls opened this issue 1 year ago • 8 comments

PR-Codex overview

The focus of this PR is to export EngineAccountOptions and engineAccount from engine-account.js to enable engine account creation with specified options.

Detailed summary

  • Export EngineAccountOptions and engineAccount from engine-account.js
  • Add engineAccount function to create engine accounts with specified options
  • Implement methods for sending transactions, signing messages, and signing typed data
  • Handle engine requests for transaction sending, message signing, and typed data signing

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

jnsdls avatar Jul 03 '24 03:07 jnsdls

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 7:45pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 7:45pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 7:45pm

vercel[bot] avatar Jul 03 '24 03:07 vercel[bot]

⚠️ No Changeset found

Latest commit: 1fdbdca99dbda7183b5f9ce0bc1ca98b7778480a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 03 '24 03:07 changeset-bot[bot]

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

graphite-app[bot] avatar Jul 03 '24 03:07 graphite-app[bot]

  • #3821 Graphite
  • #3584 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jnsdls and the rest of your teammates on Graphite Graphite

jnsdls avatar Jul 03 '24 03:07 jnsdls

TODO: add tests

jnsdls avatar Jul 03 '24 03:07 jnsdls

CodSpeed Performance Report

Merging #3584 will not alter performance

Comparing feature/add-engine-account (1fdbdca) with main (3ffd555)

Summary

✅ 9 untouched benchmarks

codspeed-hq[bot] avatar Jul 03 '24 03:07 codspeed-hq[bot]

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.17 KB (0%) 864 ms (0%) 592 ms (+46.27% 🔺) 1.5 s
thirdweb (cjs) 91.22 KB (0%) 1.9 s (0%) 895 ms (-15.4% 🔽) 2.8 s
thirdweb (minimal + tree-shaking) 4.79 KB (0%) 96 ms (0%) 20 ms (-83.31% 🔽) 116 ms
thirdweb/chains (tree-shaking) 492 B (0%) 10 ms (0%) 9 ms (-23.57% 🔽) 19 ms
thirdweb/react (minimal + tree-shaking) 13.54 KB (0%) 271 ms (0%) 68 ms (-43.82% 🔽) 339 ms

github-actions[bot] avatar Jul 03 '24 03:07 github-actions[bot]

Codecov Report

Attention: Patch coverage is 20.44199% with 144 lines in your changes missing coverage. Please review.

Project coverage is 62.19%. Comparing base (3ffd555) to head (1fdbdca). Report is 571 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/engine-account.ts 20.44% 144 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3584      +/-   ##
==========================================
- Coverage   62.32%   62.19%   -0.14%     
==========================================
  Files         963      964       +1     
  Lines       74814    74995     +181     
  Branches     3772     3767       -5     
==========================================
+ Hits        46631    46644      +13     
- Misses      27498    27668     +170     
+ Partials      685      683       -2     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3ffd555
packages 61.60% <20.44%> (-0.16%) :arrow_down:

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/engine-account.ts 20.44% <20.44%> (ø)

... and 2 files with indirect coverage changes

codecov[bot] avatar Jul 03 '24 03:07 codecov[bot]