engine icon indicating copy to clipboard operation
engine copied to clipboard

Consider allowing host.docker.internal with the http protocol for local development

Open r-marques opened this issue 8 months ago • 0 comments

Changes

  • updates isValidWebhookUrl to allow using host.docker.internal with the http protocol
  • updates the validator unit tests to check if http://host.docker.internal:3000 is a valid webhook url

This makes it possible to set webhooks for services running on the host when developing locally and running the engine with docker


PR-Codex overview

This PR updates the validation logic for webhook URLs to include host.docker.internal as a valid hostname for HTTP requests, enhancing local development compatibility.

Detailed summary

  • Added a test case in tests/unit/validator.test.ts to validate http://host.docker.internal:3000.
  • Modified the validation logic in src/server/utils/validator.ts to include host.docker.internal in the list of allowed hostnames for HTTP.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

r-marques avatar Apr 29 '25 14:04 r-marques