dotnet icon indicating copy to clipboard operation
dotnet copied to clipboard

Support Sophon ZkSync AA

Open 0xFirekeeper opened this issue 1 year ago • 1 comments

PR-Codex overview

The focus of this PR is to add support for a new chain ID (531050104) in the existing ZkSync functionality.

Detailed summary

  • Added support for chain ID 531050104 in Utils.cs
  • Updated Program.cs to include functionality for chain ID 531050104
  • Modified SmartWallet.cs to handle transactions for chain ID 531050104
  • Added new test cases for chain ID 531050104 in Thirdweb.ZkSmartWallet.Tests.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

0xFirekeeper avatar Sep 13 '24 16:09 0xFirekeeper

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.91%. Comparing base (fd18d3d) to head (ba03b70).

Files with missing lines Patch % Lines
...irdweb/Thirdweb.Wallets/SmartWallet/SmartWallet.cs 16.66% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   87.02%   86.91%   -0.12%     
==========================================
  Files          26       26              
  Lines        3776     3782       +6     
  Branches      525      526       +1     
==========================================
+ Hits         3286     3287       +1     
- Misses        490      495       +5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 13 '24 16:09 codecov-commenter