puppet-sysctl icon indicating copy to clipboard operation
puppet-sysctl copied to clipboard

Update init.pp

Open schlitzered opened this issue 4 years ago • 3 comments

Some sysctl values return "tabs", this breakes the test for changes, since there is no sane way to specify tabs in the target value.

this change converts tabs in the output of sysctl -n to two spaces. resolving this issue of false positive change detection

schlitzered avatar Feb 26 '21 09:02 schlitzered

@thias this PR is now over a year old. Do you think there is a chance to get it merged?

fetzerms avatar Feb 07 '22 23:02 fetzerms

I ran Puppet with your updates and it did not fix:

kernel.sem net.ipv4.ip_local_port_range net.ipv4.route.flush

If I change the sed tab-replace line to substitue one space instead of two spaces, then only net.ipv4.route.flush is broken.

I'll look into the code to see if there's more needed to fix the net.ipv4.route.flush.

bschonec avatar Jun 14 '22 10:06 bschonec

net.ipv4.route.flush isn't something that Puppet should manage because it's not a setting but more of a method to clear the routing table (and hence causes a change).

I've submitted https://github.com/schlitzered/puppet-sysctl/pull/1 to THIS pull request to fix the issue.

bschonec avatar Jun 23 '22 14:06 bschonec