sof icon indicating copy to clipboard operation
sof copied to clipboard

testbench: dont build testbench, tools and topologies in the source directory

Open lgirdwood opened this issue 10 months ago • 8 comments

Currently all topologies, testbench and some tools are built within the FW source directory unlike FW which has separate binary destination directories outside of the main FW source directory.

This series moves all tools, testbench and topologies binaries to outside the source directory to the parent SOF "workspace" directory alongside the FW build output directories.

lgirdwood avatar Mar 03 '25 18:03 lgirdwood

I expect this to break CI if we have hard coded assumptions of where to find certain binaries. @singalsu pls take a look.

lgirdwood avatar Mar 03 '25 18:03 lgirdwood

This depends on https://github.com/thesofproject/sof/pull/9870 so DNM as for now.

lgirdwood avatar Mar 05 '25 13:03 lgirdwood

Changes for V2:

  1. Check for SOF_WORKSPACE environment for non default installs.
  2. Added @singalsu patch.

lgirdwood avatar Apr 01 '25 13:04 lgirdwood

depends on https://github.com/thesofproject/sof/pull/9870

lgirdwood avatar Apr 08 '25 14:04 lgirdwood

@jsarha fyi - was meaning this one.

lgirdwood avatar May 20 '25 19:05 lgirdwood

Rebased now that #9870 is merged

lgirdwood avatar May 20 '25 20:05 lgirdwood

Needs Jenkins update to merge.

Yeah - hopefully the last one. @cgturner1 pls see jenkins build i.e. we no longer build tools in the src directory.

/usr/bin/mkdir -p -m 0755 /home/cwd_user/work/sof/tools/var/lib/alsa
make[3]: Leaving directory '/home/cwd_user/work/sof/alsa-utils'
make[2]: Leaving directory '/home/cwd_user/work/sof/alsa-utils'
make[1]: Leaving directory '/home/cwd_user/work/sof/alsa-utils'
Build and installation complete for /home/cwd_user/work/sof/alsa-utils
All repositories processed.
mkdir: cannot create directory '/home/sof/work/sof.git/../build-tools-tplg': Permission denied

lgirdwood avatar May 23 '25 11:05 lgirdwood

ok will need to take a look...a lot of the issues stem from the user settings (in scripts/sudo-cwd.sh) being done in the docker which seem to be from the way it mounts uses the local volumes as a workspace

and it sems to restrict the user "cwd" from creating directories in certain places ...ideally this docker should run as the sof user and we would be fine..i'll need to figure out the change to get this to cooperate at least to get the mkdir to work.

will run some tests and update when i get this updated

cgturner1 avatar May 23 '25 17:05 cgturner1