sof icon indicating copy to clipboard operation
sof copied to clipboard

pipeline 2.0 - introduce abstract audio_buffer api

Open marcinszkudlinski opened this issue 1 year ago • 3 comments

This PR introduces an abstract struct sof_audio_buffer which should become a base abstract class for all buffer types in pipeline 2.0 PR should be neutral for all functionality

On the generic pipeline code there MUST NOT be any other usage of buffers but:

  • sof_audio_buffer for maintenance operations
  • sof_sink
  • sof_source

(with obvious exception for buffer creation - see concept of "buffer factory)

this PR change usage of DP_queue (renamed to ring_buffer) to match the above request

marcinszkudlinski avatar Jun 26 '24 15:06 marcinszkudlinski

Development is of course still in progress, but this PR looks like a good subset. Please proceed with review.

marcinszkudlinski avatar Jul 04 '24 07:07 marcinszkudlinski

@marcinszkudlinski good stuff - CI looking good too, just a minor conflict.

lgirdwood avatar Jul 05 '24 13:07 lgirdwood

as to codestyle check failure:

WARNING: please write a help paragraph that fully describes the config symbol

I did, the symbol is fully described, but checkpatch is blind to this.

marcinszkudlinski avatar Jul 05 '24 15:07 marcinszkudlinski

rebased

marcinszkudlinski avatar Jul 08 '24 10:07 marcinszkudlinski

I missed one commit during rebase

marcinszkudlinski avatar Jul 09 '24 06:07 marcinszkudlinski

This compilation failure seems relevant: https://github.com/thesofproject/sof/actions/runs/9852402212/job/27200883856?pr=9260

marc-hb avatar Jul 09 '24 17:07 marc-hb

One case of https://github.com/thesofproject/sof/issues/9191 in https://sof-ci.01.org/sofpr/PR9260/build6422/devicetest/index.html , rest looks clean. Merging.

kv2019i avatar Jul 10 '24 12:07 kv2019i