sof icon indicating copy to clipboard operation
sof copied to clipboard

library_manager: add missing "depends on CONFIG_LLEXT"

Open marc-hb opened this issue 1 year ago • 3 comments

Block the possibility of compiling library_manager without CONFIG_LLEXT, which obviously fails with dozens of linker errors.

PS: I have no idea why library_manager depends on IPC_MAJOR_4. Kconfig is designed to express actual code dependencies, not "supported" configurations.

marc-hb avatar Jun 11 '24 23:06 marc-hb

Loadable modules tests failed in https://sof-ci.01.org/sof-pr-viewer/#/build/PR9222/build14036351 so this requires more investigation.

marc-hb avatar Jun 12 '24 00:06 marc-hb

which build target it is affecting? Loadable modules are feature supported from mtl and up.

pjdobrowolski avatar Jun 12 '24 06:06 pjdobrowolski

I see a related Kconfig fix in #9199, so maybe that helped. Will try again.

Loadable modules are feature supported from mtl and up.

This does not matter. See commit message:

Kconfig is designed to express actual code dependencies, not "supported" configurations.

There is at least one, non-Intel configuration with Zephyr+IPC3 right now. I doubt it will ever want to use LLEXT but it is not Kconfig's job to stop that and it should be possible to try as long as there's no incompatibility at the code level.

Kconfig is not a project management tool or bug tracking tool.

https://docs.zephyrproject.org/latest/build/dts/dt-vs-kconfig.html

marc-hb avatar Jun 12 '24 19:06 marc-hb

No time to get to the bottom of this. Just filed more generic:

  • #9386

marc-hb avatar Aug 23 '24 00:08 marc-hb