sof icon indicating copy to clipboard operation
sof copied to clipboard
verified publisher icon thesofproject

Audio: Optimize and fix TDFB direction calculation

Open ShriramShastry opened this issue 1 year ago • 1 comments

This check-in refines the TDFB direction calculation, addressing both performance and correctness:

  • Fixes:
  • Correct infinite loop in max_mic_distance by fixing loop conditions.
  • Optimizations:
  • Fix off-by-one error in line_array_mode_check ensuring all checks for co-linearity among microphone locations are performed.

ShriramShastry avatar May 27 '24 11:05 ShriramShastry

It's not clear if you want to keep #9160, or want to include the previous change into this PR (and close #9160). I think separate PR is better, so you should keep #9160 and remove the first commit from this PR.

singalsu avatar May 27 '24 15:05 singalsu

Lets wait for @singalsu to return before we merge.

We don't have CI validation for these features and @ShriramShastry is without DUTs to run tests. So bear with me, I need to test this manually before approve. Right now there is higher priority work for a new platform.

singalsu avatar Jul 19 '24 08:07 singalsu

Adding that this PR saves when sound angle tracking is enabled in TGL 4 mic case from 134 MCPS average to 120 MPCS average. Also test tools/test/audio/tdfb_direction_test.m is passed.

singalsu avatar Jul 19 '24 09:07 singalsu

Failures in https://sof-ci.01.org/sofpr/PR9169/build5921/devicetest/index.html , but the TDFB not part of these topologies, so can' be related. Proceeding with merge, thanks @ShriramShastry !

kv2019i avatar Aug 05 '24 07:08 kv2019i