sof icon indicating copy to clipboard operation
sof copied to clipboard

[FEATURE][IPC4] Adjust DSP frequency based on pipeline cost data (CPC/CPS)

Open kv2019i opened this issue 2 years ago • 7 comments

Is your feature request related to a problem? Please describe. The pipeline create messages provide enough data to describe the cycle budget for a particular pipeline and its configuration. DSP should use this information to adjust the DSP operation point on platforms that support this.

SOF A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like One version outside main in https://github.com/thesofproject/sof/commit/553b2a646bb1172d274429aefb8a64d2fd98256d

Additional context Blocking merge of https://github.com/thesofproject/sof/pull/7233

FYI @abonislawski @mwasko @ujfalusi @lgirdwood @kfrydryx @pblaszko

kv2019i avatar Mar 14 '23 09:03 kv2019i

Implemented in https://github.com/thesofproject/sof/pull/6649 , closing.

kv2019i avatar Aug 08 '23 14:08 kv2019i

Sorry, was a bit too fast on this. We still need the pipeline changes in https://github.com/thesofproject/sof/pull/8019 to complete this.

kv2019i avatar Aug 09 '23 09:08 kv2019i

Assigning as per owner of https://github.com/thesofproject/sof/pull/8019

kv2019i avatar Sep 25 '23 18:09 kv2019i

As we all know, current MTL clock only have two options, 38.4mhz and 393.216mhz, seems we only need take Wov as 38.4mhz and others all run at max freq, we may implement this as now for current solution.

Later, we still need a way to adjust each core dsp clock based on overall pipeline performance when HW support 100/200, we can think about how to implement this in future.

is above thinking reasonable and applicable?

btian1 avatar Nov 15 '23 02:11 btian1

The WoV clock only makes sense if ONLY core0 is used.

Once you have more than 1 core used, then the assumption is that you need quite a bit of processing power.

I would be surprised anyways if we can select the clock individually for each core. IIRC this a global setting for all cores. Please check.

plbossart avatar Nov 15 '23 16:11 plbossart

This seems to need more time, pushing to v2.9.

kv2019i avatar Nov 24 '23 17:11 kv2019i

Implemented available and reviewed at https://github.com/thesofproject/sof/pull/8019 but merge blocked due to failing test cases. Pushing to 2.10.

kv2019i avatar Mar 04 '24 13:03 kv2019i

With #8019 merged, we can now close this.

kv2019i avatar Apr 24 '24 10:04 kv2019i