sof icon indicating copy to clipboard operation
sof copied to clipboard

[RFC] Add Dummy codec to slove dai issue of echo-ref

Open gongjun-song opened this issue 3 years ago • 3 comments

For codec max98357, it is not reasonable to use it as capture dai for echo reference, because it only supports playback.

Set dummy codec for echo reference to solve this issue.

Signed-off-by: Gongjun Song [email protected]

gongjun-song avatar Jul 21 '22 09:07 gongjun-song

the sof-dev PR associated with this PR: https://github.com/thesofproject/linux/pull/3753

gongjun-song avatar Jul 21 '22 09:07 gongjun-song

@lgirdwood The problem is for simple amplifiers that don't provide an echo reference. On some devices, the echo reference is generated by the firmware, but in that case we don't have a physical SSP that's tied to the echo reference pipeline. All the attempts I've seen do a silly inclusion of a pretend SSP just to get the job done, and there were multiple attempts that were never validated and it's been broken for a while.

The real fix would be to stop using a pretend SSP - and have some way of modeling the loopback done before rendering data on the playback SSP.

I don't have time to look into this, it's been broken for a very very long time I am afraid.

plbossart avatar Aug 01 '22 16:08 plbossart

I don't have time to look into this, it's been broken for a very very long time I am afraid.

understood - I guess we will have to live with this in the short term until a valid solution can be upstreamed.

lgirdwood avatar Aug 02 '22 09:08 lgirdwood

Thanks @lgirdwood, Let's wait a suitable solution, I will closed this PR

gongjun-song avatar Aug 29 '22 01:08 gongjun-song