thesofproject
scripts/qemu-check.sh: Add qemu check for mt8195 platform
This commit adds mt8195 into the supported platforms in qemu-check.sh. Please help review it.
Can one of the admins verify this patch?
reply test this please to run this test once
Eventually this should be added to the matrix in .github/workflows/pull-request.yml too otherwise it will "bitrot"
@marc-hb Should I update ".github/workflows/pull-request.yml" too, or you will help update it when #4186 is fixed.
@wenliangwu pls check your email, I've sent invite so that CI will run automatically from now on (starts at your next PR)
@wenliangwu pls check your email, I've sent invite so that CI will run automatically from now on (starts at your next PR)
Done. Thanks for your invite.
Add now if it works, later if not yet.
@marc-hb I think it can't work now, because mt8195 isn't included in the qemu docker image. Do you suggest me put mt8195 to gcc-build-only list first?
On the other hand, qemu docker image seems to be built from sof-v4.2, but I submitted qemu patch for mt8195 to sof-v5.2.0 (thesofproject/qemu@b85c079). Should I also upload the patch to sof-v4.2? Thanks.
When invoked without any argument the script iterates on all SUPPORTED_PLATFORMS. So we can't really merge this before it actually works.
@wenliangwu there is also this possibility: SCRAP
EDIT: sorry I meant https://github.com/thesofproject/sof/commit/c7fc085bd52e9cf6952b4ecc6b5d56c36cc54e79
@lgirdwood As marc-hb mentioned, this is still blocked by https://github.com/thesofproject/sof/issues/4186.
@marc-hb Do you mean I can still add mt8195 to SUPPORTED_PLATFORM; on the other hand, add DEFAULT_PLATFORM excluding mt8195 to keep the default behavior?
add DEFAULT_PLATFORM excluding mt8195 to keep the default behavior?
Yes this is what I meant exactly. Copy the feature that makes a difference between SUPPORTED_ vs DEFAULT_ from the other scripts. Copy that feature only if you think it will make your life easier, otherwise don't bother.
