devcontainer icon indicating copy to clipboard operation
devcontainer copied to clipboard

Fix medusa installation using multi-stage build

Open EperezOk opened this issue 1 year ago • 2 comments

In the current version of the Dockerfile, medusa is not being installed.

This PR installs medusa using a multi-stage build. This way, the go installation can be removed from the main container.

EperezOk avatar Jul 20 '24 02:07 EperezOk

Isn't it installed by crytic-compile? I'm pretty sure I checked this on my tests. Maybe I forgot to add pipx install medusa?

mattaereal avatar Aug 05 '24 21:08 mattaereal

From the docs and my tests, I'm 98% sure it's neither installed by crytic-compile nor available through pipx.

EperezOk avatar Aug 06 '24 02:08 EperezOk

Thanks for the contribution, and I will look into it, but the way you suggested is not the way we would like to accomplish this.

You're deleting asdf installation among other things. I'll add an issue to address this in the future.

Thanks again <3

mattaereal avatar Aug 28 '24 15:08 mattaereal

I came back to this because I almost ended up implementing medusa like this (hehe), which is exactly what ToB did to install it on their container. The thing is that I still want to keep asdf as a tool :).

Thanks again for this PR!

mattaereal avatar Jan 17 '25 12:01 mattaereal