iodata icon indicating copy to clipboard operation
iodata copied to clipboard

Update overlap.py to fix_factorial2

Open LudoRNLT opened this issue 2 years ago • 3 comments

Capture d'écran 2024-03-07 104652 Capture d'écran 2024-03-07 104853

@D-TheProgrammer and I, think that we solved the factorial error. Let us know if we have to do this but in a different way or use another syntax.

LudoRNLT avatar Mar 07 '24 10:03 LudoRNLT

Hi @PaulWAyers and @FarnazH , @LudoRNLT and I wanted to know if you have any updates regarding our fix and if it still suits you for the merge.

D-TheProgrammer avatar Apr 03 '24 10:04 D-TheProgrammer

I think @FarnazH is busy. Perhaps @tovrstra or @marco-2023 has time to do a quick review.

PaulWAyers avatar Apr 03 '24 13:04 PaulWAyers

@D-TheProgrammer: can you explain the error you were getting and that was fixed with this change? I just ran all unit tests without this change, and they pass (except for the problem fixed in #310).

Edit: sorry found it #308

tovrstra avatar May 03 '24 06:05 tovrstra

I'm closing this one because a more recent pull request was made: #319

tovrstra avatar Jun 01 '24 17:06 tovrstra