grid icon indicating copy to clipboard operation
grid copied to clipboard

General class for N body grid integrations

Open marco-2023 opened this issue 2 years ago • 5 comments

Added module and class for generic N grid integrations. This class is the base framework and on top of it, some porcelain will be added for the coulomb-exchange integrals.

marco-2023 avatar Sep 18 '23 17:09 marco-2023

Thanks, @PaulWAyers for your feedback. I will certainly make the tutorial. Before that, I plan to implement the porcelain needed for the class so that the obtained grid (used for representing the k-electron distribution function) can be used for calculating the coulomb type integrals seamlessly (without having undefined values for any of the points).

marco-2023 avatar Sep 20 '23 14:09 marco-2023

At first I'd just compute normalization of the distribution functions. Then we can work on coulomb integrals in a second step.

PaulWAyers avatar Sep 20 '23 14:09 PaulWAyers

Perfect, I will do so then. Thank you very much.

marco-2023 avatar Sep 20 '23 14:09 marco-2023

@sanchezw17 The Basegrid should not be changed to accommodate the Ngrid class. I will work on an example and see if I can reproduce your problem.

marco-2023 avatar Feb 06 '24 13:02 marco-2023

@sanchezw17 I made the corrections to the ngrid and added some tests. Now It is possible to use grids of different dimensions for the same function. At some point an example notebook will be needed but for now, you can see the tests. Please let me know if you have any problem after the corrections.

marco-2023 avatar May 24 '24 04:05 marco-2023

I went through this PR again, still LGTM. I will be merging it.

marco-2023 avatar Feb 10 '25 21:02 marco-2023