grid icon indicating copy to clipboard operation
grid copied to clipboard

Molecular Grid from Atomic Grids

Open PaulWAyers opened this issue 2 years ago • 4 comments

There should be an easy-to-use functionality to get molecular grids from atomic grids, as well as an overall wrapper to take atomic positions and types and construct atomic grids directly, then molecular grids.

PaulWAyers avatar Aug 17 '23 15:08 PaulWAyers

A starting point is to add a notebook that shows how to construct a molecular grid from atomic grids.

PaulWAyers avatar Aug 30 '23 19:08 PaulWAyers

I agree with adding in the notebook on how to construct it using the initializer but I feel like the init method achieves the easy-to-use functionality if the user has an example

https://github.com/theochem/grid/blob/cdf1ec3d4282421968b3db215417f6fd09f486bc/src/grid/molgrid.py#L92-L98

There is also an example of using init in the code docs of molecular grid

The latter wrapper will depend on the radial grid and consequently the results of the grid assessment for picking a default radial grid

Ali-Tehrani avatar Aug 31 '23 12:08 Ali-Tehrani

Until grid assessment is done, the default construction methods in mol_grid would be changed so that the rgrid methods and aim_weights are from Horton/Becke Weights, respectively.

Ali-Tehrani avatar Nov 17 '23 15:11 Ali-Tehrani

  • [ ] Address comments 1 and 2 from https://github.com/theochem/grid/pull/199#pullrequestreview-1738493652
  • [ ] Double check the 2nd formula in the “Calculate Radial Electron Density Distribution” section
  • [x] Probably we can identify the maximum radial electron density distribution using scipy

FarnazH avatar Dec 24 '23 18:12 FarnazH