ModelHamiltonian icon indicating copy to clipboard operation
ModelHamiltonian copied to clipboard

Array transformation become a free function

Open Bakugo90 opened this issue 2 years ago • 6 comments

FIxes #54

As suggested by PhD @msricher :

These functions, which do not use self or reference the parent object, should probably be free functions in utils, and then added to init.py

I just move to_parse function to utils.py and then define it on __init__.py so it can be access through the package name moha

Bakugo90 avatar Feb 22 '24 00:02 Bakugo90

Hi @Bakugo90! Great job! It seems like some of the style-related tests need to be fixed.

RichRick1 avatar Feb 25 '24 20:02 RichRick1

Thank you @RichRick1 ... Some pycodestyle errors I've just fixed it.

Bakugo90 avatar Feb 25 '24 21:02 Bakugo90

@Bakugo90 great job! I'd change one more thing: it seems like we need to exclude docs and example folders from the precommit.

RichRick1 avatar Mar 01 '24 15:03 RichRick1

we need to exclude docs and example folders from the precommit.

Done ! @RichRick1

Bakugo90 avatar Mar 01 '24 18:03 Bakugo90

Hello mentors @RichRick1 , @PaulWAyers

As we prepare to expand the existing package by introducing new occupation-and-spin based hamiltonian, have we compiled a list of the specific Hamiltonians to be included during this Gsoc ?

I'm currently working on outlining a timeline for implementation, and having clarity on which Hamiltonians to include and their exact quantity would greatly assist me in managing my time effectively.

Bakugo90 avatar Mar 11 '24 10:03 Bakugo90

@Bakugo90 Because there are implemented the most general spin-based XXZ Heisenberg hamiltonian and the most general occupation-based Pariser-Parr-Pople hamiltonian, the general spin-based and occupation-based hamiltonian should just inherit both classes. However, it would be nice to narrow it down to t-J-U-V and t-J model.

RichRick1 avatar Mar 14 '24 20:03 RichRick1

@RichRick1 is this something we can close?

PaulWAyers avatar Oct 26 '24 03:10 PaulWAyers

Yes!

RichRick1 avatar Oct 28 '24 13:10 RichRick1