angular2-lightbox icon indicating copy to clipboard operation
angular2-lightbox copied to clipboard

package.json incorrect, breaks with incompatible versions

Open noerw opened this issue 7 years ago • 1 comments

I can't use this module, because it does not declare its dependencies correctly (all in the devDependencies field):

rxjs, @angular/core, possibly more should go into dependencies.

This breaks, when you have different versions in your project, e.g. rxjs v6:

./node_modules/angular2-lightbox/lightbox-event.service.js
Module not found: Error: Can't resolve 'rxjs/Subject' in '/home/norwin/src/eumetsat-new-pn/pn-ng6/node_modules/angular2-lightbox'

noerw avatar Jul 26 '18 09:07 noerw

To support rxjs v6, could you please use this module instead https://github.com/themyth92/ngx-lightbox. Current module will not support v6

themyth92 avatar Jul 26 '18 10:07 themyth92