diffxpy icon indicating copy to clipboard operation
diffxpy copied to clipboard

volcano plots specifications

Open davidsebfischer opened this issue 6 years ago • 2 comments

Just a note... I also have some code to make a volcano plot in line [111] here. Don't know if this is still needed, but I thought I would see if someone cares.

@davidsebfischer do you allow labels in your volcano plot function? And can it take any object, or only some custom diffxpy ones? If these things aren't a problem I'd prefer to use yours tbh.

Originally posted by @LuckyMD in https://github.com/theislab/scanpy/issues/460#issuecomment-471522186

davidsebfischer avatar Mar 11 '19 13:03 davidsebfischer

I thought this was better dealt with here. I did not understand the question fully, what type of object would you want to call the volcano plot on? Right now it only handles diffxpy objects. I will to add gene lables, right now you can only color certain target genes in the plot.

davidsebfischer avatar Mar 11 '19 13:03 davidsebfischer

I have a pandas dataframe with gene names, fold changes, and adjusted p-values. That's all you need for a volcano plot really...

A nice specification would be the ability to zoom into a particular region. But of course you can do that by subsetting the dataframe as well.

LuckyMD avatar Mar 11 '19 14:03 LuckyMD