diffxpy icon indicating copy to clipboard operation
diffxpy copied to clipboard
verified publisher icon theislab

Preparing v0.8

Open ilan-gold opened this issue 3 years ago • 3 comments

Pairs with https://github.com/theislab/batchglm/pull/146

This PR aims to upgrade batchglm. The main outstanding question mentioned on slack is whether the 5 failing tests in test_constrained.py and test_pairwise_null.py should be deleted. It seems to me that they are trying to do the impossible by fitting more than one scale parameter but I feel somewhat uncertain here because I have had trouble with constraints before and I am not familiar with Z-tests. Other than that, feel free to ask why I did anything!

ilan-gold avatar Jul 13 '22 15:07 ilan-gold

Can I rebase this branch to dev? Just so that we can merge through there. Once both this and the corresponding PR on batchglm are in the respective dev branches, I would then advance them to release, incremementing the dependency version of batchglm in diffxpy as well.

davidsebfischer avatar Jul 14 '22 08:07 davidsebfischer

Ah yes of course! I was wondering what was up with that - it seems like master is ahead of dev?

ilan-gold avatar Jul 14 '22 10:07 ilan-gold

Ah yes of course! I was wondering what was up with that - it seems like master is ahead of dev?

Those were small fixes it seems, I rebased them into dev. I think the rebase caused two minor conflicts, as shown in the summary of the PR.

davidsebfischer avatar Aug 06 '22 12:08 davidsebfischer