foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #35414 - Bump Sidekiq to 6.3.z

Open adamruzicka opened this issue 3 years ago • 2 comments

As a side effect, gitlab-sidekiq-fetcher should get updated to >= 7.1.0.

Currently latest sidekiq is 6.5.5, but anything above 6.4.0 is rather verbose about things being deprecated in sidekiq 7.0.0.

Fixing those deprecations is tracked as https://projects.theforeman.org/issues/35413

Similarly, latest redis is 4.8.0, but anything above 4.5.0 is rather verbose about things being deprecated in redis 5.0.0. Note, those deprecation warnings are triggered from inside of gitlab-sidekiq-fetcher.

This issue has been reported as https://gitlab.com/gitlab-org/sidekiq-reliable-fetch/-/issues/32

To test these changes in development

# Prerequisite - have redis available
# podman run -p 6379:6379 --name redis1 -d redis:7-alpine

# cat >orchestrator.yaml <<EOF
:concurrency: 1
:queues:
    - dynflow_orchestrator
EOF

# cat >worker.yaml <<EOF
:concurrency: 10
:queues:
    - default
    - remote_execution
EOF

# cat >config/initializers/foreman_tasks.rb <<EOF
# config/initializers/foreman_tasks.rb
if defined?(ForemanTasks) && Rails.env != 'test'
  ForemanTasks.dynflow.config.remote = true
end
EOF

# bundle exec sidekiq -e development -r $PWD/extras/dynflow-sidekiq.rb -C orchestrator.yaml

# bundle exec sidekiq -e development -r $PWD/extras/dynflow-sidekiq.rb -C worker.yaml

There's also related issue https://projects.theforeman.org/issues/35415, but that can be fixed independently.

adamruzicka avatar Aug 23 '22 08:08 adamruzicka

Issues: #35414

theforeman-bot avatar Aug 23 '22 08:08 theforeman-bot

Issues: #35414

theforeman-bot avatar Aug 23 '22 08:08 theforeman-bot