wave icon indicating copy to clipboard operation
wave copied to clipboard

UI tweaks, script tweak and bug fixes

Open 7Skiez opened this issue 4 years ago • 10 comments

Great work, Thought it'd be cool to add some UI changes, little bug fixes and script improvements.

7Skiez avatar May 11 '21 08:05 7Skiez

bilalnurcan47 avatar May 14 '21 04:05 bilalnurcan47

@7Skiez thanks for the PR. The code looks good and I appreciate the fixes; however, it does appear that these UI tweaks have messed up some alignment on the homepage. Here's is quick screencast:

https://www.loom.com/share/6a2d81836ec74ba6ab35a3f77e1199b1

Your branch is the one in the first tab, compare that to the 2nd tab and it looks like there are some alignment issues. If you can get this fixed, I can take another look and then get this merged in.

Thanks again!

tnylea avatar May 20 '21 02:05 tnylea

See the last comment in the thread. There are a few alignment issues that this PR has created:

https://www.loom.com/share/6a2d81836ec74ba6ab35a3f77e1199b1

Thanks!

@tnylea Thanks man, Pleasure to be working on the project, Sorry I forgot changing the promo image in the seeders, The whole point of this UI change was to add a floating boat/ship to go with the wave/voyager paradigm (I'm not sure if this could be a new theme or something you could configure through admin). I've added a few more demo ship images in the public theme directory, They're interchangeable through the admin panel.

wave_ships_demo

I changed the width for dropdown containers for this not to happen when the text/content gets smaller :

w-screen_vs_w-max However if you didn't like the look of it so far, I could just put in the changes for code (excluding UI).

7Skiez avatar May 20 '21 15:05 7Skiez

@7Skiez Love those images!

thanks for this PR. I'll be taking a look at it today. Looks super cool! And thanks for the menu UI updates.

tnylea avatar May 23 '21 17:05 tnylea

This piece of code will help fixing the sequence and auto incrementing problem on PostgreSQL the-control-group/voyager#3563 after seeding the pgsql database, This will help fixing the unique violation error and allows normal use.

if (config('database.default') === 'pgsql') {
   $tables = \DB::select('SELECT table_name FROM information_schema.tables WHERE table_schema = \'public\' ORDER BY table_name;');
   foreach ($tables as $table) {
      if (\Schema::hasColumn($table->table_name, 'id')) {
         $seq = \DB::table($table->table_name)->max('id') + 1;
         \DB::select('SELECT setval(pg_get_serial_sequence(\'' . $table->table_name . '\', \'id\'), coalesce(' . $seq . ',1), false) FROM ' .$table->table_name);
      }
   }
}

7Skiez avatar May 24 '21 03:05 7Skiez

@7Skiez Thanks for these fixes. Loving it!

Before I merge this in, I want to guarantee that it's available to run on PHP7 and PHP8, currently, this PR has a composer.lock file that requires spatie/macroable locked at 2.0 which requires PHP 8.

Here's the error screen that I get when I try and install a fresh copy from your PR branch:

CleanShot 2021-05-27 at 21 43 45@2x

@bobbyiliev and I are working to get some more tests into the system so that way stuff like this can be checked when a PR is opened. I might suggest trying to remove spatie/ray or macroable from your composer.json.

Hope you understand, I want to make sure that as many people who pull the latest version of Wave are able to install it, even if they are on PHP7.

Thanks! Keep me posted with the progress on this. Appreciate all the help.

tnylea avatar May 28 '21 04:05 tnylea

@tnylea Hi, I got the same error running php 8 on my machine, I'll revert back the lock file and make a new commit.

image

7Skiez avatar May 28 '21 19:05 7Skiez

CleanShot 2021-05-27 at 21 43 45@2x

Try running composer install --ignore-platform-reqs instead, It helps with this issue.

7Skiez avatar May 29 '21 00:05 7Skiez

@tnylea Please checkout thedevdojo/themes#3 I tried adding a radio button to be able to switch between layouts, and found this bug, Now I need this merged in before I send one last commit.

7Skiez avatar May 29 '21 11:05 7Skiez

Added hero layout radio button switch inside admin, theme options.

image

image

7Skiez avatar May 29 '21 23:05 7Skiez