fdir icon indicating copy to clipboard operation
fdir copied to clipboard
verified publisher icon thecodrr

Fixed unit tests on Windows machines

Open eulerfields opened this issue 4 years ago • 3 comments

  • Added getWorkingRoot function which returns the root directory of CWD; replaced references to the root system mount point "/" with references to getWorkingRoot.
  • Replaced hard-coded references to Linux filesystem features with dynamic references dependent on process.platform or existing platform-agnostic functions.
  • Added missing configuration options for mock-fs to avoid dirent re-creation errors.

eulerfields avatar Apr 12 '21 15:04 eulerfields

Hey, thank you so much for working on this! I don't have a Windows machine; can you help me setup CI on Windows in this PR or another PR so we can confirm this works?

thecodrr avatar Apr 14 '21 04:04 thecodrr

Once this PR gets merged, I'm happy to help get the CI working for Windows. I got it working using a fork of this branch here (notice that they're all passing). Once the conflicts are resolved in this PR and it gets merged, I will submit a proper PR for the CI build script.

TwitchBronBron avatar Mar 12 '22 20:03 TwitchBronBron

@eulerfields there are some conflicts with the master branch. Would you be able to resolve them so that this PR can be merged? If not, I'm happy to pick up the branch and submit a new PR with these fixes and the fixes for the merge conflicts.

TwitchBronBron avatar Mar 12 '22 21:03 TwitchBronBron

All tests are now passing on all platforms after #81

thecodrr avatar Apr 07 '23 01:04 thecodrr