lobibox icon indicating copy to clipboard operation
lobibox copied to clipboard

Notification not vertically aligned

Open eazrael opened this issue 6 years ago • 0 comments

After upgrading to a recent version, I found a regression, in notifications the icon is no longer vertically aligned: bad With the old version it was properly aligned: good

I did a git bisect and ironically it was caused by a commit named "Align icon/image vertically center":

git bisect start
# bad: [4f7a51543127fff6b661af1710b84a82fda6779f] Update version in package.json
git bisect bad 4f7a51543127fff6b661af1710b84a82fda6779f
# good: [d2b81f5eef87156f8a09b2d3499241f953ec1153] my first commit
git bisect good d2b81f5eef87156f8a09b2d3499241f953ec1153
# good: [790ea176ca1d3e877f90ec7002c78d12dc1fd661] fixed bugs for lobibox
git bisect good 790ea176ca1d3e877f90ec7002c78d12dc1fd661
# good: [a8ee1ca01c99e5c008e6157e4914e3b5631cd17c] Working on to make large notifications independent from bootstrap
git bisect good a8ee1ca01c99e5c008e6157e4914e3b5631cd17c
# bad: [1735632c1c608ab2562eedb6e1fa7b7026a408d7] Added option to show notification at any place
git bisect bad 1735632c1c608ab2562eedb6e1fa7b7026a408d7
# good: [0c4e63b995e99138a7aae85247450a3df57de87c] Merge pull request #13 from trestini/master
git bisect good 0c4e63b995e99138a7aae85247450a3df57de87c
# bad: [b7e61891eb9e23b683fecc67e45d77b7cc30517f] Align icon/image vertically center
git bisect bad b7e61891eb9e23b683fecc67e45d77b7cc30517f
# good: [b282a73fefffb1306d6e721c69e800072b9715ed] Added dependency with jquery ^1.11
git bisect good b282a73fefffb1306d6e721c69e800072b9715ed
# good: [c01234ae4e224bcea40237cb581c4c3488a0029b] Changed default animation on notifications. Added black color notification.
git bisect good c01234ae4e224bcea40237cb581c4c3488a0029b
# first bad commit: [b7e61891eb9e23b683fecc67e45d77b7cc30517f] Align icon/image vertically center

My testcode is quite short: Lobibox.notify("error", { size: "normal", msg: "Test", delay: false, icon: "warning icon" });

eazrael avatar Mar 04 '19 22:03 eazrael