301RedirectModule icon indicating copy to clipboard operation
301RedirectModule copied to clipboard

Sitecore 9 Compatability

Open rdonnelly02 opened this issue 7 years ago • 12 comments

Hello,

Is this module compatible in Sitecore 9? I tried to install the module and upon changing the RedirectModule.Config values for the settings (below) to true

I am getting an exception:

Exception information: Exception type: MissingMethodException Exception message: Method not found: 'Sitecore.Links.LinkProvider Sitecore.Links.LinkManager.get_Provider()'. at SharedSource.RedirectModule.Processors.RedirectProcessor.CheckForRegExMatch(Database db, String requestedUrl, String requestedPathAndQuery, HttpRequestArgs args) at SharedSource.RedirectModule.Processors.RedirectProcessor.Process(HttpRequestArgs args) at (Object , Object[] ) at Sitecore.Pipelines.CorePipeline.Run(PipelineArgs args) at Sitecore.Pipelines.DefaultCorePipelineManager.Run(String pipelineName, PipelineArgs args, String pipelineDomain) at Sitecore.Web.RequestEventsHandler.OnPostAuthenticateRequest(HttpContextBase context) at Sitecore.Nexus.Web.HttpModule.’(Object “, EventArgs ”) at System.Web.HttpApplication.SyncEventExecutionStep.System.Web.HttpApplication.IExecutionStep.Execute() at System.Web.HttpApplication.ExecuteStepImpl(IExecutionStep step) at System.Web.HttpApplication.ExecuteStep(IExecutionStep step, Boolean& completedSynchronously)

Is there something else that I need to configure?

rdonnelly02 avatar Jul 11 '18 20:07 rdonnelly02

Nope, that looks like they removed a method in Sitecore 9 and it seems it'll require some code changes to fix.

cadamsdotcom avatar Jul 11 '18 22:07 cadamsdotcom

That's what I was afraid of...

Few additional questions:

-Is this something that you plan on working on by any chance, or should we go about developing internally?

-Do you know of any workarounds that we could potentially try?

-Do you have any recommendations of tools/modules that might work in SC9?

Thanks so much for your response!

rdonnelly02 avatar Jul 11 '18 22:07 rdonnelly02

Sorry but I'm not going to be able to help out validating this. It took me many months to convince Sitecore to give me a trial license, and then I find out that you have to write code to get the damn thing to install - even just with reasonable defaults!? If I was a well-paid consultant I'd be very happy with this state of affairs, but I'm not. Anyway so I tried a bunch of times to get a working Sitecore 9 installation and got tripped up by a never ending series of troubles getting windows, visual studio, solr, SQL Server, and Sitecore install framework to talk to each other. Microsoft's VMs they package have a 30-day expiry on Visual Studio and a 90-day expiry on WIndows, and Sitecore only gives a 60-day license, so everything is just going to expire on me even if I snapshot the VM. Unfortunately Visual Studio has already expired on every VM I can download from Microsoft, and for some reason the expired license for the version of Visual Studio they package prevents me using VS community edition, it just shuts down after a few minutes. For me to be willing to spend the time, I need to see Microsoft get serious about free-to-use software instead of crippling their stuff with trials, I'll need to see Sitecore take an interest in the "default everything except X and Y" use case that I as an open-source maintainer care about, and I'll need to not have to spend another 10-12 months trying to get a trial license out of them after this one expires. In the meantime though I am going to cease working on this module.

I will, however, merge a PR if it is code-reviewed by someone from another GitHub organization.

cadamsdotcom avatar Jul 20 '18 22:07 cadamsdotcom

Man! Okay, no worries at all. If that’s he route the team goes down, I’ll definitely let you know. Thanks again for getting back to me.

rdonnelly02 avatar Jul 31 '18 17:07 rdonnelly02

No worries! If you wanted to get a PR merged though I’m more than happy to - just need that review :)

cadamsdotcom avatar Jul 31 '18 17:07 cadamsdotcom

We have a need for this module (were using it in 8.2 update 2 then upgraded to 9 initial) We have someone looking through the code. Would you be willing to package a Sitecore 9 version once we submit a pull request?

bkschmitz avatar Oct 16 '18 15:10 bkschmitz

Sure thing. I’d be happy to.

On Tue, 16 Oct 2018 at 8:18 am, bkschmitz [email protected] wrote:

We have a need for this module (were using it in 8.2 update 2 then upgraded to 9 initial) We have someone looking through the code. Would you be willing to package a Sitecore 9 version once we submit a pull request?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/thecadams/301RedirectModule/issues/40#issuecomment-430278206, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-_f3rxN-bYrV__Q7OcUkeeZ7mpsfEFks5ulfhOgaJpZM4VLzqJ .

cadamsdotcom avatar Oct 16 '18 15:10 cadamsdotcom

I created a pull request with the changes for Sitecore 9.

mdownermindstream avatar Oct 16 '18 17:10 mdownermindstream

There's now also a pull request for upgrade to Sitecore 9.1

kaalen avatar Jun 18 '19 01:06 kaalen

Is there a release with the Sitecore 9 changes?

estockwell-alpert avatar Jul 22 '19 17:07 estockwell-alpert

Sure! The latest release should be Sitecore 9 compatible.

On Mon, 22 Jul 2019 at 10:26 am, estockwell-alpert [email protected] wrote:

Is there a release with the Sitecore 9 changes?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/thecadams/301RedirectModule/issues/40?email_source=notifications&email_token=AAP367ZP5EGV6LHSIYWTHELQAXUU7A5CNFSM4FJPHKE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2QSH5Y#issuecomment-513876983, or mute the thread https://github.com/notifications/unsubscribe-auth/AAP3672SWM2LFJTOOJVFOVDQAXUU7ANCNFSM4FJPHKEQ .

cadamsdotcom avatar Jul 22 '19 17:07 cadamsdotcom

thank you!

estockwell-alpert avatar Jul 22 '19 17:07 estockwell-alpert