html.tmbundle icon indicating copy to clipboard operation
html.tmbundle copied to clipboard

Syntax highlighting is broken for handlebars comments

Open alexr00 opened this issue 3 years ago • 0 comments

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.73.1
  • OS Version: Darwin x64 21.6.0

Steps to Reproduce:

  1. Create a file called helloworld.hbs and paste this there: {{!-- outer comment {{!-- inner comment --}} {{hello --}} Below is what you see on the screen. index view — project_panther_fe 2022-12-06 16-34-05

  2. Visit https://handlebarsjs.com/playground.html and in the template section, also paste the above string. Then open your browser console, you will notice compile errors. Below is what you see on the screen. Handlebars 2022-12-06 16-31-51

According to the the handlebars parser (also as you can see in the handlebars playground as well), the first "--}}" encountered terminates the comment. But VS Code tricks the developer into thinking that the comment is only terminated after the last "--}}". This will lead to errors and a poor experience

Originally opened by @tonyobanon in https://github.com/microsoft/vscode/issues/168179

alexr00 avatar Dec 07 '22 13:12 alexr00