testing-library-docs icon indicating copy to clipboard operation
testing-library-docs copied to clipboard

ecosystem page for react-hooks-testing-library

Open rawat07102 opened this issue 5 years ago • 5 comments

#20

rawat07102 avatar Oct 11 '20 07:10 rawat07102

Hi @rawat07102! Thanks for this PR.. If you want in to automatically link the issue, you'll need to write something like: "Resolves #20", then the issue will be automatically closed once this PR will be merged.. Also, I'm second thinking whether this should be placed in eco-system or under the React section since this is related only to React.. Any thoughts?

MatanBobi avatar Oct 11 '20 08:10 MatanBobi

thanks for the suggestion @MatanBobi and it does make sense for it to be under React section but it does not depend on react-testing-library. So I guess it depends on if we want to separate based on dependency or use case.

rawat07102 avatar Oct 11 '20 14:10 rawat07102

thanks for the suggestion @MatanBobi and it does make sense for it to be under React section but it does not depend on react-testing-library. So I guess it depends on if we want to separate based on dependency or use case.

I agree, it's a little tricky but logically I'd go with that, I guess more opinions would be good.. Also, I saw that under ecosystem we already have rtl-simple-queries which is clearly related only to React..

MatanBobi avatar Oct 11 '20 17:10 MatanBobi

This page should go under the ecosystem section. It's where all of the libraries that aren't framework adapters go.

alexkrolick avatar Oct 13 '20 19:10 alexkrolick

@rawat07102 can you please resolve the conflicts so we'll be able to merge this one? :)

MatanBobi avatar Apr 22 '21 16:04 MatanBobi