dom-testing-library icon indicating copy to clipboard operation
dom-testing-library copied to clipboard

Leverage levenshtein distance to help users debug easily when there are close matches

Open zikaari opened this issue 5 years ago • 5 comments

Describe the feature you'd like:

Sometimes, due to minor typo or an extra space here and there, a match is not successful and queries throw the error. Due to the typo being non-obvious (like double-space or a dash instead of em-dash etc), it isn't always an instantaneous pin-point to where the problem is.

I think it might be very useful for the users if they see something like this:

Unable to find an element with exact match: 15-25

Found close matches. Did you mean one of these:
  15–25
  19–22

<div>
	<ul> ... </ul>
</div>

Suggested implementation:

When a candidate node is tested for a match, also calculate levenshtein distance from its textContent to the target string, and push the score to an array (along with the node itself). After all nodes are tested, and no match is found, sort the array on distance score and suggest top 3 close candidates to the user.

zikaari avatar May 19 '20 17:05 zikaari

I've considered this and think it would be really cool. However, I'm worried that this will be very challenging to do well. I don't have the bandwidth to work on it myself, but I would be willing to look at a pull request for it.

kentcdodds avatar May 19 '20 17:05 kentcdodds

Note that this doesn't mean it would get merged. So keep that in mind. It would need to not complicate the codebase more than is reasonable.

kentcdodds avatar May 19 '20 17:05 kentcdodds

I'm worried that this will be very challenging to do well

what challenges do you see off top of your head?

zikaari avatar May 19 '20 18:05 zikaari

Just feels like there are dragons lurking. I could be wrong though 😅

kentcdodds avatar May 19 '20 20:05 kentcdodds

I created a proof of concept to gather some feedback. If there is interest i can finish it up 👍

dougbacelar avatar Nov 21 '20 09:11 dougbacelar