cypress-testing-library icon indicating copy to clipboard operation
cypress-testing-library copied to clipboard

Update @testing-library/dom

Open zenblender opened this issue 2 years ago • 1 comments

  • cypress-testing-library version: 9.0.0
  • node version: 19.4.0
  • npm (or yarn) version: 9.2.0

Problem description:

Should this be updated with the latest @testing-library/dom? (Currently 9.3.1)

I’ve noticed incompatibilities with other libraries that use the latest version of @testing-library/dom, such as @testing-library/react and @testing-library/user-event. Having both versions 8 and 9 in a project causes confusion and errors, for example about whether user-event actions need to be wrapped in act.

Suggested solution:

Update cypress-testing-library to use the latest version of @testing-library/dom.

zenblender avatar Aug 22 '23 20:08 zenblender

Bumping.

Because of difference between versions of @testing-library/react and @testing-library/cypress I've got error like you mentioned.

console.error
  Warning: The current testing environment is not configured to support act(...)

I see there is pending PR https://github.com/testing-library/cypress-testing-library/pull/262 .

Since it looks like there is no breaking change between versions, I'm working with pnpm.packageExtensions till there is version bump:

"pnpm": {
  "packageExtensions": {
    "@testing-library/[email protected]": {
      "dependencies": {
        "@testing-library/dom": "^9.0.0"
      }
    }
  }
}

radoslawgrochowski avatar Sep 04 '23 11:09 radoslawgrochowski