testcontainers-python icon indicating copy to clipboard operation
testcontainers-python copied to clipboard

fix(kafka): wait_for_logs in kafka container to reduce lib requirement

Open gudjonragnar opened this issue 2 years ago • 6 comments

Use wait_for_logs to wait for startup instead of waiting for successful connection via kafka-python. Also removes the dependency on kafka-python.

Closes #351

gudjonragnar avatar Aug 01 '23 09:08 gudjonragnar

LGTM, we would really like to see this because we use confluent kafka in the project...

jankatins avatar Oct 19 '23 16:10 jankatins

@gudjonragnar Will you find time to get this running on top of the current main branch? If not: would you mind if I take this and rebase (or rework, if needed) and open it as a new PR (I will keep your handle as co-author on the commit)?

jankatins avatar Feb 28 '24 13:02 jankatins

I will try to find some time beginning of next week 👍

gudjonragnar avatar Mar 01 '24 21:03 gudjonragnar

Should be up to date now, unless I missed something with the big changes done to the repo

gudjonragnar avatar Mar 03 '24 18:03 gudjonragnar

https://github.com/gudjonragnar/testcontainers-python/pull/1

alexanderankin avatar Mar 04 '24 02:03 alexanderankin

Reminder to myself to get this merged #446

alexanderankin avatar Mar 11 '24 10:03 alexanderankin