testcontainers-node icon indicating copy to clipboard operation
testcontainers-node copied to clipboard

Add Clickhouse module

Open tomershafir opened this issue 2 years ago • 7 comments

Add basic clickhouse module

tomershafir avatar Sep 04 '23 10:09 tomershafir

Deploy Preview for testcontainers-node ready!

Name Link
Latest commit 47a9adf8bb365621fa67549e946947d2f545c85d
Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/65ae97a1e56c580008b46a3a
Deploy Preview https://deploy-preview-648--testcontainers-node.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 04 '23 10:09 netlify[bot]

@tomershafir please add your module under modules add file https://github.com/testcontainers/testcontainers-node/blob/main/mkdocs.yml. Otherwise it will be missing in the documentation.

djakielski avatar Jan 21 '24 19:01 djakielski

done, @cristianrgreco hey, can you merge?

tomershafir avatar Jan 21 '24 20:01 tomershafir

Thanks @tomershafir, please address the linting issues. The security alerts could also be solved by replacing Math.random() with a uuid (we have a UUID generator). I know it's for test only but it'd be nice not to get alerted each time a change is made here.

cristianrgreco avatar Jan 22 '24 10:01 cristianrgreco

done

tomershafir avatar Jan 22 '24 12:01 tomershafir

Thanks @eddumelendez :slightly_smiling_face: Will merge when the build passes

cristianrgreco avatar Jan 23 '24 14:01 cristianrgreco

@tomershafir This test is failing: should work with custom database and custom yaml config (120432 ms)

cristianrgreco avatar Jan 23 '24 15:01 cristianrgreco

Closing due to inactivity.

cristianrgreco avatar Nov 28 '24 19:11 cristianrgreco