testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

GH-8558 Make Ryuk shutdown hook configurable.

Open mmaeller opened this issue 1 year ago • 7 comments

Description

#7717 added the Ryuk shutdown hook. Unfortunately, this leads to some issues e.g. with spring-boot like #8558. With this PR I want to make the initial feature configurable.

mmaeller avatar May 28 '24 13:05 mmaeller

Any progress on this issue?

s-jepsen avatar Jun 28 '24 11:06 s-jepsen

Any update?

ahmed-marzook avatar Jul 29 '24 17:07 ahmed-marzook

Any progress on this issue?

s-jepsen avatar Aug 09 '24 06:08 s-jepsen

Why is this PR still in the freezer after nearly 3 months?

Has any feedback been provided as to why the proposed change has not yet been approved? Are there any concerns on the part of the reviewers that we could work through? The way I read it, this change is purely about adding a configurable option to testcontainers configuration such that we can bypass an early termination of the containers and Spring Application Context beans that use those services can coalesce gracefully. Why is this so controversial?

alex-arana avatar Aug 13 '24 01:08 alex-arana

@eddumelendez Could you please take a look please?

jpalaz avatar Aug 13 '24 08:08 jpalaz

Any updates? Is there a way to move forwards with this change?

mariuszptasinskii avatar Sep 24 '24 06:09 mariuszptasinskii

Please see my considerations in this comment in the original issue, which explains why we don't just merge this change, although it would allow for a workaround: https://github.com/testcontainers/testcontainers-java/issues/8558#issuecomment-2411172007

kiview avatar Oct 14 '24 13:10 kiview

We have decided to revert the change and it will be part of the next release.

eddumelendez avatar Nov 15 '24 15:11 eddumelendez