testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard

Prefer to use new ClickHouse JDBC driver

Open pan3793 opened this issue 3 years ago • 4 comments

pan3793 avatar Aug 02 '22 04:08 pan3793

@pan3793 thanks for the PR! but switching drivers seems to fail when com.clickhouse.jdbc.ClickHouseDriver is used against yandex/clickhouse-server:18.10.3. If the image is upgraded to, for example, yandex/clickhouse-server:21.3.20.1-alpine then succeeds. Due to we don't know which image versions are used, we can not accept the PR as-is for now. Unless , the image version is also take it into account in order to resolve the right driver.

eddumelendez avatar Aug 16 '22 17:08 eddumelendez

Thanks for review and tips, and also cc @zhicwu for suggestions since he is the clickhouse-jdbc maintainer

pan3793 avatar Aug 16 '22 17:08 pan3793

Thanks @pan3793 for the PR!

Hi @eddumelendez, ClickHouse 18.x is not in active releases and it's no longer supported according to this. Can we upgrade image to clickhouse/clickhouse-server:21.8? I think we can drop the legacy driver, but it's fine to keep it as fallback in case there's work still rely on that.

zhicwu avatar Aug 16 '22 22:08 zhicwu

@zhicwu regardless of what we are using internally, users can do new ClickHouseContainer("yandex/clickhouse-server:18.10.3") or new ClickHouseContainer("clickhouse/clickhouse-server:21.9.2-alpine") with any version and in order to provide a great experience and give the chance to users to upgrade on their own we need to manage this compatibility somehow. In the future, for a major release, we can drop any yandex reference :)

eddumelendez avatar Aug 16 '22 22:08 eddumelendez

This was addressed already in #6236 depending on the image version.

eddumelendez avatar Mar 14 '23 19:03 eddumelendez