testcontainers-java icon indicating copy to clipboard operation
testcontainers-java copied to clipboard
verified publisher icon testcontainers

Replace deprecated RabbitMQ SSL environment variables with configuration file (#5599)

Open mgryszko opened this issue 3 years ago • 1 comments

This PR enables configuring RabbitMQ SSL for RabbitMQ 3.9+ versions. Until 3.9, SSL could be configured by environment variables. These variables were deprecated in RabbitMQ 3.9 version. If defined, the broker is generating an error on startup.

We solved this issue by adding an additional advanced configuration file that is merged with the default configuration file included in the Docker image. We chose this solution because the advanced configuration is not configured using Testcontainers DSL and it doesn't interfere with the optional configuration added with withRabbitMQConfig method.

Co-authored-by: Joan Fisbein [email protected] Co-authored-by: Marcin Gryszko [email protected]

On-behalf-of: @clarityai-eng [email protected]

Fixes #5599

mgryszko avatar Jul 15 '22 13:07 mgryszko

@mgryszko any update on this?

eddumelendez avatar Dec 15 '22 01:12 eddumelendez

@jgiovaresco feel free to make a proposal. If you'd like to discuss it then openning a GH Discussion would be ok then we can turn it into an issue. If you have the PR ready then we can discuss it there too.

I'm closing this one looking after the new PR.

eddumelendez avatar Jul 31 '23 00:07 eddumelendez