Methods exceeded maximum allowed ABC complexity

[joelreymont]

Rake is failing for unknown reasons on my Mac.

rake -tv ** Invoke default (first_time) ** Invoke quality (first_time) ** Invoke cane (first_time) ** Execute cane

Methods exceeded maximum allowed ABC complexity (1):

lib/kitchen/driver/docker.rb Kitchen::Driver::Docker#build_run_command 16

Lines violated style requirements (7):

lib/kitchen/driver/docker.rb:32 Line is >80 characters (88) lib/kitchen/driver/docker.rb:36 Line is >80 characters (115) lib/kitchen/driver/docker.rb:37 Line is >80 characters (92) lib/kitchen/driver/docker.rb:65 Line is >80 characters (91) lib/kitchen/driver/docker.rb:168 Line is >80 characters (85) lib/kitchen/driver/docker.rb:218 Line is >80 characters (93) lib/kitchen/driver/docker.rb:250 Line is >80 characters (88)

Class and Module definitions require explanatory comments on previous line (1):

lib/kitchen/driver/docker/erb.rb:23 DockerERBContext

Total Violations: 9

[peterabbott]

Until merge requests are applied, the easiest way to get past this is updating cane file with

--max-violations 10

For example: https://github.com/peterabbott/kitchen-docker/blob/master/.cane

I have also started a forked version of the driver because the owner of this one does not seem to respond to any PR's or questions.

https://github.com/peterabbott/kitchen-docker_ssh

[joelreymont]

@peterabbott Why the _ssh?

[peterabbott]

I had to come up with a unique name to publish to rubygems repo. This uses ssh to provision instead of docker exec that another similar driver uses.

I have also a forked version https://github.com/peterabbott/kitchen-docker that contains all the same fixes, and trying to feed back into this one.

At the moment the main difference is that I setup circleci to test before doing the automated publish and looking to add unit tests