react-native-camera-kit icon indicating copy to clipboard operation
react-native-camera-kit copied to clipboard

added code format to see type of code scanned

Open android-imdad opened this issue 2 years ago • 5 comments

Summary

Added codeFormat to see what kind of code is being scanned, useful when there is code specific validation that needs to be done.

How did you test this change?

Tested example apps on both IOS and Android, no visual change for screenshot.

android-imdad avatar Dec 22 '23 11:12 android-imdad

Hi, yes will check these comments in a few days

android-imdad avatar Dec 26 '23 18:12 android-imdad

@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns.

android-imdad avatar Feb 18 '24 07:02 android-imdad

@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns.

Thanks @android-imdad. Have you tried it? I doubt the iOS part compiles at all.

When I said to replace AVMetadataObject.ObjectType by CodeFormat, there is more than just changing a type. It has to be reflected all along the chain. On both camera & simulator, as well as in CameraProtocol

DavidBertet avatar Feb 18 '24 17:02 DavidBertet

@DavidBertet I fixed the indentation, accepted your changes and added types. Please review and let me know if there are any concerns.

Thanks @android-imdad. Have you tried it? I doubt the iOS part compiles at all.

When I said to replace AVMetadataObject.ObjectType by CodeFormat, there is more than just changing a type. It has to be reflected all along the chain. On both camera & simulator, as well as in CameraProtocol

My bad, nope didn't try it after the change. Will test it and do a commit with the fixes.

android-imdad avatar Feb 18 '24 18:02 android-imdad

@DavidBertet Please check now, I made the changes and tested in both IOS and Android, seems to be working as expected.

android-imdad avatar Feb 22 '24 04:02 android-imdad

Thanks @android-imdad and @DavidBertet !

scarlac avatar Apr 30 '24 23:04 scarlac