react-native-camera-kit icon indicating copy to clipboard operation
react-native-camera-kit copied to clipboard

Typescript definition & documentation example doesn't match

Open koiralakiran1 opened this issue 4 years ago • 4 comments

Issue Description

  1. The documentation here shows that CameraScreen supports actions props but the typescript suggestion/definition doesn't reflect that.
  2. Also, multiple props are mentioned in the same docs/snippet as optional but they are shown as required props in typescript definition as shown in the screenshot below.

Here's what I mean: image

Should the documentation be updated or is the actions prop not supported?

Let me know if I'm missing sth here.

Steps to Reproduce / Code Snippets / Screenshots

  • Use the library on an RN project with Typescript support

[FILL THIS OUT - It will be extremely helpful]


Environment

  • React Native Navigation version: // Question: Should this be React Native Camera Kit Version, in the issue template?? React Native Navigation = v7.0.0 React Native Camera Kit = v11.1.0
  • React Native version: 0.63.2
  • Platform(s) (iOS, Android, or both?): I usually run on android (but Might not be relavent anyways)
  • Device info (Simulator/Device? OS version? Debug/Release?): Device -> Android 10 (Debug) (Might not be relavent anyways)

If there's something simple that I could help out with here, I'd be happy to look into it and create a PR.

koiralakiran1 avatar Apr 21 '21 16:04 koiralakiran1

I discovered the same

milan2sky avatar Mar 03 '22 16:03 milan2sky

Any update on this one? The documentation seems to be completely unreliable regarding the Typescript definition. e.g. flashImages is not listed in the component props but actually used in the implementation.

TommyBez avatar Sep 30 '22 07:09 TommyBez

@scarlac we can close this one. Documentation & typescript definition has been updated recently

DavidBertet avatar Jun 30 '23 16:06 DavidBertet

That @DavidBertet !

scarlac avatar Jul 01 '23 15:07 scarlac