Feat: bring up share function

Open SukkaW opened this issue 3 years ago • 3 comments

The PR supersedes #25:

Use gzip and js-base64 (url-safe base64 built in) to generate share url
Use existing evalConfig instead of a home-baken deserializer

Jul 29 '22 17:07 SukkaW

@fabiosantoscode Kindly request your attention with a friendly ping. My PR has been open for a year. I would greatly appreciate it if you could spare some time to review it, at your convenience, and provide your valuable feedback.

Jul 30 '23 10:07 SukkaW

I can't really merge this because evalOptions calls eval, making it an XSS risk.

Jul 31 '23 14:07 fabiosantoscode

I can't really merge this because evalOptions calls eval, making it an XSS risk.

Any reason to keep using eval? It seems that most options are simple JSON-stringifiable options.

Sep 07 '23 15:09 mariomc