tensorflow icon indicating copy to clipboard operation
tensorflow copied to clipboard
Published 4 weeks ago • verified publisher icon tensorflow

[TF-TRT] Add LogSoftmax Support for TF-TRT

Open pavanimajety opened this issue 3 years ago • 1 comments

This PR adds TF-TRT support to tf.nn.log_softmax operation. This is performed using the formula logsoftmax = logits - log(reduce_sum(exp(logits), axis=-1)) . The implemented TRT layers are fused into a single op.

@DEKHTIARJonathan @tfeher : Please review the changes.

pavanimajety avatar Aug 04 '22 21:08 pavanimajety

@pavanimajety Please add a PR description.

bixia1 avatar Aug 09 '22 16:08 bixia1

Looks good to me now. Would you please squash the commits?

Done. Thanks for reviewing

pavanimajety avatar Aug 10 '22 15:08 pavanimajety

Sorry, rebased for further work by mistake.

pavanimajety avatar Aug 12 '22 18:08 pavanimajety

This is merged, wonder why it doesn't show as merged here.

bixia1 avatar Aug 12 '22 22:08 bixia1

This is merged, wonder why it doesn't show as merged here.

Would you mind checking again? I don't see in tensorflow:master : https://github.com/tensorflow/tensorflow/tree/master/tensorflow/compiler/tf2tensorrt/convert/ops

pavanimajety avatar Aug 13 '22 00:08 pavanimajety

It did not show as merged here because copybara sync was broken. Fixed in big squash commit 49f97f135a2e1d5d22e60d2a80ec668d53f9708a

mihaimaruseac avatar Aug 13 '22 16:08 mihaimaruseac