tensorflow icon indicating copy to clipboard operation
tensorflow copied to clipboard

Converter for SelectV2 operation.

Open drivanov opened this issue 3 years ago • 4 comments

Implementation of converter for ops::SelectV2 operation.

drivanov avatar Jul 01 '22 21:07 drivanov

@bixia1: I am still working on improving this PR. In particular, I implement the ability to use broadcast forms for the cond, then, and else tensors. My last check-in already contains most of this implementation, but I plan to add a few more tests. For instance, currently, the case when all three tensors have different broadcastable shapes is not covered.

drivanov avatar Jul 20 '22 18:07 drivanov

@bixia1: I am done with all the tests for this PR.

drivanov avatar Jul 21 '22 22:07 drivanov

@drivanov can you take care of this, it say cla/google failure.

bixia1 avatar Jul 28 '22 17:07 bixia1

@bixia1 : I'm done with this PR. Please review. Thanks!

drivanov avatar Aug 03 '22 00:08 drivanov

I fixed this issue by deleting the ConvertSelectV2 class and the corresponding test for TRT < 8.2. There is no point in having them because this converter expects cond to be passed as a boolean tensor, which can only be created for TRT >= 8.2.

drivanov avatar Aug 23 '22 18:08 drivanov

@bixia1: Please, don't merge that one into master. I have resolved the formal merge conflicts appeared after the merge of PR#56942, but I need to fix something.

drivanov avatar Aug 24 '22 16:08 drivanov

@bixia1: I fixed all merge conflicts. This PR is ready to merge.

drivanov avatar Aug 24 '22 17:08 drivanov

Can you please rebase your branch to head, Thank you.

rthadur avatar Aug 24 '22 21:08 rthadur

REBASED

drivanov avatar Aug 24 '22 23:08 drivanov