runtime icon indicating copy to clipboard operation
runtime copied to clipboard

Fold rules_cuda into bazelbuild/rules_cuda

Open dmadisetti opened this issue 4 years ago • 4 comments

Ideally rules_cuda should be split away from this project. Even the README of rules_cuda has the repo located at its own repository.

You probably have this tracked internally, but for the rest of us, I thought it would be a good idea to open this ticket as somewhere we can refer. I get that this is probably pretty low priority.

Thanks for your work chsigg and team

dmadisetti avatar May 04 '21 16:05 dmadisetti

Hi Dylan.

You are absolutely right. @rules_cuda needs a better home. I've talked to the bazel folks before and it sounded like adding it to bazelbuild would come with a relatively high maintenance commitment, so I was a little on the fence. Maybe http://github.com/tensorflow/toolchains would be the better home. Hopefully this will bubble up in our priority list with TF and TFRT slowly converging.

chsigg avatar Jun 22 '21 19:06 chsigg

@chsigg the newly formed SIG rules authors may be a better home for this now; see https://github.com/bazel-contrib/SIG-rules-authors. The process to on-board rulesets hasn't been defined but feel free to start a discussion about this in the SIG-rules-authors repo if this is something you would like to do.

I certainly have an interest in the rules_cuda ruleset so would love to see it hosted outside the tensorflow/runtime repository; I would definitely support having it in bazel-contrib as a ruleset as I think having a canonical cuda ruleset available is a worthy aim.

jsharpe avatar Nov 19 '21 19:11 jsharpe

Hi James, thanks for letting me know. I would be happy to upstream this to bazel-contrib. I will get in contact with the SIG.

chsigg avatar Nov 24 '21 16:11 chsigg

https://github.com/bazel-contrib/rules_cuda has been created. Would be great to identify any gaps preventing migration of TF to use these new rules.

ryanleary avatar Nov 03 '22 15:11 ryanleary