profiler icon indicating copy to clipboard operation
profiler copied to clipboard

Bump bazel vesion to 7.4.1 to align with jax/xla?

Open yliu120 opened this issue 10 months ago • 3 comments

As titled.

XLA/JAX both bumped bazel version fo 7.4.1. It is just a pain for the community to have multiple bazel versions locally.

yliu120 avatar Mar 12 '25 21:03 yliu120

This is definitely on my radar and planning to do ASAP. We've been locked to 6.5.0 for a while now as a result of being dependent on Tensorflow, and they just updated to 7.4.1 about two weeks ago.

If it's as simple as just bumping the version (iirc there were some build issues related to deprecating the WORKSPACE file last I checked, but that might be because I was defaulting to 8.X), then feel free to submit a PR!

Matt-Hurd avatar Mar 13 '25 20:03 Matt-Hurd

Another issue with the build @Matt-Hurd :

#23 82.71 INFO: From SassCompiler frontend/styles.css:
#23 82.71 Error: "headline1-font-family already has a link"
#23 82.71    ╷
#23 82.71 48 │       $unused: keys.add-link(keys.combine($style, $base-key), $base-key);
#23 82.71    │                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
#23 82.71    ╵
#23 82.71   node_modules/@material/typography/_typography.scss 48:16                                set-styles-()
#23 82.71   node_modules/@material/typography/_typography.scss 128:10                               @forward
#23 82.71   node_modules/@material/typography/_variables.scss 24:1                                  @forward
#23 82.71   @material/_index.scss 1:1                                                               @use
#23 82.71   external/npm/node_modules/@angular/material/core/mdc-helpers/_mdc-helpers.scss 8:1      @use
#23 82.71   external/npm/node_modules/@angular/material/button/_button-theme-private.scss 5:1       @use
#23 82.71   external/npm/node_modules/@angular/material/button/_button-theme.scss 10:1              @use
#23 82.71   external/npm/node_modules/@angular/material/core/density/private/_all-density.scss 2:1  @forward
#23 82.71   @angular/_index.scss 18:1                                                               @use
#23 82.71   frontend/styles.scss 1:1                                                                root stylesheet
#23 82.71 ERROR: /root/profiler/frontend/BUILD:71:12: output 'frontend/styles.css' was not created
#23 82.71 ERROR: /root/profiler/frontend/BUILD:71:12: SassCompiler frontend/styles.css failed: not all outputs were created or valid
#23 82.94 Target //plugin:build_pip_package failed to build
#23 82.94 Use --verbose_failures to see the command lines of failed build steps.
#23 82.94 INFO: Elapsed time: 3.557s, Critical Path: 1.77s
#23 82.94 INFO: 1507 processes: 1248 internal, 19 local, 203 processwrapper-sandbox, 37 worker.
#23 82.95 FAILED: Build did NOT complete successfully
#23 82.95 ERROR: Build failed. Not running target
#23 DONE 85.0s

I guess I still got some flakiness on this old problem.

yliu120 avatar Mar 19 '25 20:03 yliu120

I haven't seen that error before.

I tried updating our bazel version, and it seems like we're at an annoying spot. It seems like we'll need to update both our tensorboard and tensorflow versions, and it seems like they have some conflicting dependencies with rules_closure versions. I might be able to temporarily resolve this by making a patch of one of their WORKSPACEs to use a different import.

For having multiple bazel versions, you can use https://github.com/bazelbuild/bazelisk and it makes it pretty seamless as it reads from .bazelversion.

Matt-Hurd avatar Mar 19 '25 20:03 Matt-Hurd

I've gotten a PR to a good place: https://github.com/openxla/xprof/pull/1278

Just need to go through a bit more testing as well as get it reviewed internally.

Matt-Hurd avatar Apr 11 '25 01:04 Matt-Hurd

Completed as of https://github.com/openxla/xprof/commit/8c0bfffeaa0625f7590f299202ad49d06457e508

Matt-Hurd avatar Apr 23 '25 23:04 Matt-Hurd