ngraph-bridge icon indicating copy to clipboard operation
ngraph-bridge copied to clipboard

Cavusmustafa/modular backend review v6

Open cavusmustafa opened this issue 5 years ago • 2 comments

cavusmustafa avatar Dec 17 '20 01:12 cavusmustafa

Requesting some cosmetic changes Please remove commented code, use CamelCase for function names

I'm confused about using CamelCase. Some function names does not use it in bridge now. Is there a plan to update them all?

cavusmustafa avatar Dec 18 '20 20:12 cavusmustafa

Requesting some cosmetic changes Please remove commented code, use CamelCase for function names

I'm confused about using CamelCase. Some function names does not use it in bridge now. Is there a plan to update them all?

Yes, we will update the function names that don't follow it

kanvi-nervana avatar Dec 18 '20 22:12 kanvi-nervana