Incorrect Documentation for MetricConfig

Open sumitbinnani opened this issue 4 years ago • 0 comments

Describe the problem

It seems like the config does not rely on the __init__ method; and relies on the get_config and from_config method of the (custom) metrics class.

This distinction is important as TFX's Evaluator serialize and deserialize the metric and __init__ is not used during the final metrics evaluation. Not sure if the issue should be raised with TFX or TFMA.

https://github.com/tensorflow/model-analysis/blob/4ea7d16125d26aa469dc2c5199bbb5f588586fef/tensorflow_model_analysis/proto/config.proto#L407-L414

Link to TFX Issue: https://github.com/tensorflow/tfx/issues/4022

Jul 12 '21 23:07 sumitbinnani