lucid icon indicating copy to clipboard operation
lucid copied to clipboard
verified publisher icon tensorflow

Save should set mime types when uploading to GCS

Open shancarter opened this issue 6 years ago • 2 comments

Unfortunately, this requires a little refactoring.

shancarter avatar Jun 10 '19 21:06 shancarter

https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Complete_list_of_MIME_types

shancarter avatar Jun 10 '19 21:06 shancarter

I did a hacky version of this for html (https://github.com/tensorflow/lucid/blob/master/lucid/misc/io/saving.py#L184).

Unfortunately, my version slows down save a bunch because it separately invokes gsutil. I think @ludwigschubert has an idea for a better version, but would be more work.

colah avatar Jun 10 '19 23:06 colah