graphics icon indicating copy to clipboard operation
graphics copied to clipboard

Add skew coefficient to camera projection API

Open fulkast opened this issue 5 years ago • 1 comments

This PR (related to #335) modifies the camera.perspective API to take into account the skew coefficient in the projection and unprojection functions.

In general the change to the API adds an extra argument skew to most functions, with the default value of None. This makes it compatible with old code, unless the users used to pass in a name without explicitly stating the keyword.

Additionally, the intrinsics_from_matrix method now returns a 3-tuple instead of a 2-tuple, and would require the users to update the call-sites.

fulkast avatar Jul 07 '20 19:07 fulkast

Hi @G4G

Thank you for your review!

What's the next step before this can be merged?

Best, Frank

fulkast avatar Mar 11 '21 20:03 fulkast