estimator icon indicating copy to clipboard operation
estimator copied to clipboard

_save_first_checkpoint in tf.keras.estimator.model_to_estimator should only be called on chief

Open sharkdtu opened this issue 6 years ago • 6 comments

when run in distribute mode, it will cause race condition of _save_first_checkpoint. So, we should judge if its task_type is chief.

sharkdtu avatar Jan 05 '20 09:01 sharkdtu

@sharkdtu Can you please resolve conflicts? Thanks!

gbaned avatar Apr 14 '21 12:04 gbaned

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Apr 15 '21 08:04 google-cla[bot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Apr 15 '21 08:04 google-cla[bot]

@sharkdtu Can you please resolve conflicts? Thanks!

gbaned avatar Jul 15 '21 15:07 gbaned

@sharkdtu Can you please resolve conflicts? Thanks!

gbaned avatar Aug 18 '21 11:08 gbaned

@sharkdtu Can you please resolve conflicts? Thanks!

done

sharkdtu avatar Aug 18 '21 14:08 sharkdtu

Hi @sharkdtu Can you please check @mihaimaruseac's comments and resolve conflicts?. Thank you!

gbaned avatar Dec 16 '22 13:12 gbaned

Closing stale PR. Note that Estimator is no longer active, currently it's only updated as needed to fully deprecate from TF.

mihaimaruseac avatar Dec 29 '22 16:12 mihaimaruseac